Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41431106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnBuilder.scala ---
@@ -109,16 +113,20 @@ private[sql] class StringColumnBuilder extends
NativeColumnBuilder(new StringCol
private[sql] class BinaryColumnBuilder extends ComplexColumnBuilder(new
BinaryColumnStats, BINARY)
-private[sql] class FixedDecimalColumnBuilder(
- precision: Int,
- scale: Int)
- extends NativeColumnBuilder(
- new FixedDecimalColumnStats(precision, scale),
- FIXED_DECIMAL(precision, scale))
+private[sql] class CompactDecimalColumnBuilder(dataType: DecimalType)
+ extends NativeColumnBuilder(new DecimalColumnStats(dataType),
COMPACT_DECIMAL(dataType))
+
+private[sql] class DecimalColumnBuilder(dataType: DecimalType)
+ extends ComplexColumnBuilder(new DecimalColumnStats(dataType),
DECIMAL(dataType))
--- End diff --
For non-compact decimal, we use `ByteArrayColumnType`, so maybe use
`ObjectColumnStats` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
