Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41455135
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -245,7 +247,8 @@ private[sql] class FixedDecimalColumnStats(precision:
Int, scale: Int) extends C
val value = row.getDecimal(ordinal, precision, scale)
if (upper == null || value.compareTo(upper) > 0) upper = value
if (lower == null || value.compareTo(lower) < 0) lower = value
- sizeInBytes += FIXED_DECIMAL.defaultSize
+ // TODO: this is not right for DecimalType with precision > 18
+ sizeInBytes += 8
--- End diff --
For decimals with precision greater than 18,
`CatalystSchemaConverter.minBytesForPrecision` can be useful here. At least it
provides a relatively tight upper limit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
