Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -321,7 +321,7 @@ abstract class AggregationIterator(
// Initializing the function used to generate the output row.
protected val generateOutput: (InternalRow, MutableRow) => InternalRow =
{
val rowToBeEvaluated = new JoinedRow
- val safeOutputRow = new GenericMutableRow(resultExpressions.length)
+ val safeOutputRow = new
SpecificMutableRow(resultExpressions.map(_.dataType))
--- End diff --
These changes in `AggregationIterator.scala` are just some minor
optimizations motivated by things that I noticed while working on the Tungsten
version. Here, and down below, I noticed that we might be unnecessarily boxing
via our use of GenericMutableRow, hence this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
