Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -170,10 +232,27 @@ class TungstenAggregationIterator(
val bufferRowSize: Int = bufferSchema.length
val genericMutableBuffer = new GenericMutableRow(bufferRowSize)
- val unsafeProjection =
- UnsafeProjection.create(bufferSchema.map(_.dataType))
- val buffer = unsafeProjection.apply(genericMutableBuffer)
- initialProjection.target(buffer)(EmptyRow)
+ // TODO(josh): figure out whether we have to use
+ val useUnsafeBuffer =
bufferSchema.map(_.dataType).forall(UnsafeRow.isMutable)
+
+ val buffer = /* if (useUnsafeBuffer) */ {
+ val unsafeProjection =
+ UnsafeProjection.create(bufferSchema.map(_.dataType))
+ unsafeProjection.apply(genericMutableBuffer)
+// } else {
+// genericMutableBuffer
+ }
+ expressionAggInitialProjection.target(buffer)(EmptyRow)
+ // TODO(josh): this can be done more cleanly
--- End diff --
I think that I thought that this block of code was a bit messy while I was
working on it. Will clean up while addressing any code review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
