Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41651685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/utils.scala ---
@@ -70,7 +70,6 @@ object Utils {
// Check if we can use TungstenAggregate.
val usesTungstenAggregate =
child.sqlContext.conf.unsafeEnabled &&
-
aggregateExpressions.forall(_.aggregateFunction.isInstanceOf[DeclarativeAggregate])
&&
--- End diff --
Can we also remove it from `planAggregateWithOneDistinct`?
For `planAggregateWithoutPartial`, we can add the flag
`usesTungstenAggregate` and whenever possible use `TungstenAggregate` (we can
do it in a separate pr.).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
