Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41648516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -546,6 +546,9 @@ case class HyperLogLogPlusPlus(child: Expression,
relativeSD: Double = 0.05)
AttributeReference(s"MS[$i]", LongType)()
}
+ override val inputAggBufferAttributes: Seq[AttributeReference] =
--- End diff --
So, if anyone tries to move it back to `ImperativeAggregate`, he/she will
see an test failure? Should we add a comment to `ImperativeAggregate` to
explain why a leaf class needs to implement this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
