Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9016#discussion_r41788877
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -34,7 +34,8 @@ import org.apache.spark.unsafe.types.UTF8String
*
* @tparam JvmType Underlying Java type to represent the elements.
*/
-private[sql] sealed abstract class ColumnType[JvmType] {
+private[sql]
+sealed abstract class ColumnType[@specialized(Boolean, Byte, Short, Int,
Long) JvmType] {
--- End diff --
Have we checked the compiled byte code to confirm this does help
eliminating boxing?
@cloud-fan For `Float` and `Double`, had offline discussion with @davies.
It's because this specialization is for simplifying `ColumnType.copyField`,
which is only used in RLE encoder, and RLE encoder doesn't support `Float` or
`Double` columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
