Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9016#discussion_r41808778
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -34,7 +34,8 @@ import org.apache.spark.unsafe.types.UTF8String
*
* @tparam JvmType Underlying Java type to represent the elements.
*/
-private[sql] sealed abstract class ColumnType[JvmType] {
+private[sql]
+sealed abstract class ColumnType[@specialized(Boolean, Byte, Short, Int,
Long) JvmType] {
--- End diff --
Checked the with `javap`, and it turned out that `ColumnType.copyField`
always calls the boxed version of `setField` and `getField`. I think we should
revert this part of changes since it's somewhat tricky to get optimal byte code
with `@specialized`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
