Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9084#discussion_r41825250
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala 
---
    @@ -40,19 +41,38 @@ private[spark] abstract class MemoryManager {
         _memoryStore
       }
     
    +  // Amount of execution/storage memory in use, accesses must be 
synchronized on `this`
    +  protected var _executionMemoryUsed: Long = 0
    +  protected var _storageMemoryUsed: Long = 0
    +
       /**
        * Set the [[MemoryStore]] used by this manager to evict cached blocks.
        * This must be set after construction due to initialization ordering 
constraints.
        */
    -  def setMemoryStore(store: MemoryStore): Unit = {
    +  final def setMemoryStore(store: MemoryStore): Unit = {
         _memoryStore = store
       }
     
       /**
    -   * Acquire N bytes of memory for execution.
    +   * Total available memory for execution, in bytes.
    +   */
    +  def maxExecutionMemory: Long
    +
    +  /**
    +   * Total available memory for storage, in bytes.
    +   */
    +  def maxStorageMemory: Long
    +
    +  // TODO: avoid passing evicted blocks around to simplify method 
signatures (SPARK-10985)
    --- End diff --
    
    Good call on deferring this to a followup task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to