Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9084#discussion_r41825331
--- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
---
@@ -72,46 +92,62 @@ private[spark] abstract class MemoryManager {
def acquireUnrollMemory(
--- End diff --
Given that `acquireUnrollMemory` appears to act as a synonym for
`acquireStorageMemory` in the current implementation, it might be worth adding
a brief comment above this method to explain that this extra method exists in
order to give us the future flexibility to account for unroll memory
differently in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
