Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9084#discussion_r41826368
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala ---
@@ -65,7 +66,7 @@ class ShuffleMemoryManager protected (
* total memory pool (where N is the # of active tasks) before it is
forced to spill. This can
* happen if the number of tasks increases but an older task had a lot
of memory already.
*/
- def tryToAcquire(numBytes: Long): Long = synchronized {
+ def tryToAcquire(numBytes: Long): Long = memoryManager.synchronized {
--- End diff --
This slightly-confusing synchronization on `memoryManager` isn't a huge
deal since it's going to be removed by the memory manager unification patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
