Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8358#discussion_r41986284
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -655,15 +655,19 @@ private[spark] object Utils extends Logging {
           // created the directories already, and that they are secured so 
that only the
           // user has access to them.
           getYarnLocalDirs(conf).split(",")
    +    } else if (conf.getenv("SPARK_LOCAL_DIRS") != null) {
    --- End diff --
    
    I agree with @vanzin.
    
    Here's the order of precedence that I think makes most sense
    
    - `SPARK_LOCAL_DIRS` environment variable
    - `spark.local.dirs` configuration
    - `MESOS_DIRECTORY` environment variable
    - `java.io.tmpdir`
    
    This way, if people don't care about the local directory they fallback to 
Mesos dir while in Mesos and `/tmp` outside. But if people *do* care, they can 
configure it. Seems to be the best of both worlds.
    
    Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to