Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8358#discussion_r42297847
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -655,15 +655,19 @@ private[spark] object Utils extends Logging {
           // created the directories already, and that they are secured so 
that only the
           // user has access to them.
           getYarnLocalDirs(conf).split(",")
    +    } else if (conf.getenv("SPARK_LOCAL_DIRS") != null) {
    +      conf.getenv("SPARK_LOCAL_DIRS").split(",")
         } else if (conf.getenv("SPARK_EXECUTOR_DIRS") != null) {
           conf.getenv("SPARK_EXECUTOR_DIRS").split(File.pathSeparator)
    +    } else if (conf.getenv("MESOS_DIRECTORY") != null
    +      && !conf.getBoolean("spark.shuffle.service.enabled", false)) {
    +      // running inside Mesos and have a local directory to use
    --- End diff --
    
    This needs to be expanded:
    ```
    // Mesos already creates a directory per Mesos task. Spark should use that 
directory
    // instead so all temporary files are automatically cleaned up when the 
Mesos task ends.
    // Note that we don't want this if the shuffle service is enabled because 
we want to
    // continue to serve shuffle files after the executors that wrote them have 
already exited.
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to