Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r42273654
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -214,7 +216,7 @@ private[ml] object TreeClassifierParams {
/**
* Parameters for Decision Tree-based regression algorithms.
*/
-private[ml] trait TreeRegressorParams extends Params {
+private[ml] trait TreeRegressorParams extends DecisionTreeParams with
HasVarianceCol {
--- End diff --
I think the best solution here would be to create a
DecisionTreeRegressorParams trait which inherits from the other param traits.
It can implement validateAndTransformSchema. The estimator & model can inherit
from it to share the implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
