Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8866#discussion_r42274055
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala 
---
    @@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
     @Experimental
     final class DecisionTreeRegressor(override val uid: String)
       extends Predictor[Vector, DecisionTreeRegressor, 
DecisionTreeRegressionModel]
    -  with DecisionTreeParams with TreeRegressorParams {
    +  with TreeRegressorParams {
    --- End diff --
    
    Btw, I think I was wrong about this being a breaking API change (because of 
the reorg you did below), but I still think we should handle this via a 
DecisionTreeRegressorParams trait.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to