Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9120#discussion_r42433852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -171,17 +171,25 @@ object ExtractEquiJoinKeys extends Logging with
PredicateHelper {
logDebug(s"Considering join on: $condition")
// Find equi-join predicates that can be evaluated before the join,
and thus can be used
// as join keys.
- val (joinPredicates, otherPredicates) =
- condition.map(splitConjunctivePredicates).getOrElse(Nil).partition
{
- case EqualTo(l, r) =>
- (canEvaluate(l, left) && canEvaluate(r, right)) ||
- (canEvaluate(l, right) && canEvaluate(r, left))
- case _ => false
- }
-
- val joinKeys = joinPredicates.map {
- case EqualTo(l, r) if canEvaluate(l, left) && canEvaluate(r,
right) => (l, r)
- case EqualTo(l, r) if canEvaluate(l, right) && canEvaluate(r,
left) => (r, l)
+ val predicates =
condition.map(splitConjunctivePredicates).getOrElse(Nil)
--- End diff --
Can you update the scaladoc to include the fact that we transform null-safe
equality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
