Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9120#discussion_r42435364
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -850,6 +851,15 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
Row(null, null, 6, "F") :: Nil)
}
+ test("SPARK-11111 null-safe join should not use cartesian product") {
+ val df = sql("select count(*) from testData a join testData b on
(a.key <=> b.key)")
+ val cp = df.queryExecution.executedPlan.collect {
+ case cp: CartesianProduct => cp
--- End diff --
ah one thing about this test case: it might be better to assert the proper
non-cartesian join operator is in place, rather than testing the cartesian
product is not in place. The reason I'm bringing this up is that I'm sure as
soon as we do local iterators (or other operator changes), this test will be a
no-op (continue passing even if the implementation is wrong).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
