Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42444143
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) with Logging {
)
}
+ @transient
+ private lazy val matcher = Pattern.compile(
+ ".*(create|drop)\\s+(temporary\\s+)?(function|macro).+",
Pattern.DOTALL).matcher("")
+
protected[hive] def runSqlHive(sql: String): Seq[String] = {
- if (sql.toLowerCase.contains("create temporary function")) {
+ val command = sql.trim.toLowerCase
+ if (matcher.reset(command).matches()) {
--- End diff --
Didn't thought about that. Matcher should not be reused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
