Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42450109
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -196,14 +194,8 @@ private[hive] object HiveShim {
if (instance != null) {
instance.asInstanceOf[UDFType]
} else {
- val func = Utils.getContextOrSparkClassLoader
+ Utils.getContextOrSparkClassLoader
.loadClass(functionClassName).newInstance.asInstanceOf[UDFType]
- if (!func.isInstanceOf[UDF]) {
--- End diff --
`instance` is now not null just for macro function, which contains detail
of how to handle input data. I've removed caching UDF because hive udf does not
coerces functions to be stateless, afaik. And I don't think creating UDF
instance will make any performance regression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
