Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9184#discussion_r42523411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -141,8 +142,73 @@ trait ScalaReflection {
ObjectType(cls)
}
+ def constructorFor(schema: StructType): Expression = {
--- End diff --
I'd consider just making an object called `RowEncoder` and put all of the
code there (including the helper functions in `EncodeUtil`). Reasoning being:
none of this uses mirrors, types or any of the other scala reflection stuff and
the code in EncodeUtil is pretty specific to Rows so doesn't need to be in its
own object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
