Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9184#discussion_r42523789
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoderSuite.scala
---
@@ -215,6 +217,42 @@ class ProductEncoderSuite extends SparkFunSuite {
protected def encodeDecodeTest[T <: Product : TypeTag](inputData: T) =
--- End diff --
Could we extend encodeDecodeTest to also just try converting `InternalRow
=> Row` and then `Row => InternalRow` and make sure the results match? That
seems like a good way to get coverage without having to repeat a lot of test
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
