Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9055#discussion_r42581809
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
---
@@ -47,4 +48,9 @@ case object RightOuter extends JoinType
case object FullOuter extends JoinType
-case object LeftSemi extends JoinType
+abstract class LeftSemiJoin extends JoinType
--- End diff --
Why have a abstract class at here? Also, looks like `LeftSemiJoin` is not a
good name since `LeftAnti` extends it and `LeftAnti` is a different concept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
