Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r42719354
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -235,8 +350,67 @@ private[streaming] class ReceivedBlockTracker(
}
}
+ /**
+ * Creates a WAL Writer in a separate thread to enable batching of log
events.
+ * Exposed for tests.
+ */
+ protected def createBatchWriteAheadLogWriter(): Option[BatchLogWriter] =
{
+ if (!WriteAheadLogUtils.isBatchingEnabled(conf)) return None
+ val writer = checkpointDirOption.map(_ => new BatchLogWriter)
+ writer.foreach { runnable =>
+ new Thread(runnable, "Batch WAL Writer").start()
+ Runtime.getRuntime.addShutdownHook(new Thread {
--- End diff --
Could you remove this shutdown hook? If you find a case
that`ReceivedBlockTracker` won't be stopped, it's better to fix it rather than
adding a shutdown hook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
