Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9127#discussion_r42802121
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -320,21 +320,20 @@ private[joins] final class UnsafeHashedRelation(
override def readExternal(in: ObjectInput): Unit =
Utils.tryOrIOException {
val nKeys = in.readInt()
// This is used in Broadcast, shared by multiple tasks, so we use
on-heap memory
- val taskMemoryManager = new TaskMemoryManager(new
ExecutorMemoryManager(MemoryAllocator.HEAP))
--- End diff --
This use of the memory managers in HashedRelation was messy before and is
slightly messier now; I'd like to find a clean way to deal with this before
merging this refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
