Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9127#discussion_r42805011
  
    --- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java 
---
    @@ -103,16 +107,39 @@
       private final boolean inHeap;
     
       /**
    -   * Construct a new MemoryManager.
    +   * Construct a new TaskMemoryManager.
    +   */
    +  public TaskMemoryManager(MemoryManager memoryManager, long 
taskAttemptId) {
    +    this.inHeap = memoryManager.tungstenMemoryIsAllocatedInHeap();
    +    this.memoryManager = memoryManager;
    +    this.taskAttemptId = taskAttemptId;
    +  }
    +
    +  /**
    +   * Acquire N bytes of memory for execution, evicting cached blocks if 
necessary.
    +   * Blocks evicted in the process, if any, are added to `evictedBlocks`.
    --- End diff --
    
    there's no `evictedBlocks` here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to