Github user yanboliang commented on the pull request:

    https://github.com/apache/spark/pull/9159#issuecomment-151042772
  
    It looks well, but I curious about whether we can figure out a more elegant 
way like this:
    ```scala
    class BlockMatrix[M <: Matrix] @Since("1.3.0") (
        @Since("1.3.0") val blocks: RDD[((Int, Int), M)],
        @Since("1.3.0") val rowsPerBlock: Int,
        @Since("1.3.0") val colsPerBlock: Int,
        private var nRows: Long,
        private var nCols: Long) extends DistributedMatrix with Logging {
    }
    ```
    Can we embrace all these cases together and make an unified constructor?
    I'm not sure it can work, just a proposal. Please let me know if it's 
unrealistic. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to