Github user javelinjs commented on the pull request:
https://github.com/apache/spark/pull/9159#issuecomment-151049530
@yanboliang Your constructor can build. But this implies exposing ```[M <:
Matrix]``` to users, we will see something like ```bm:
BlockMatrix[SparseMatrix]``` here and there, and old codes might cause type
mismatch like ```Type mismatch, expected: BlockMatrix, actual:
BlockMatrix[SparseMatrix]```
In my opinion, I think BlockMatrix should hide the underlying
implementation of its sub-matrix. Please let me know if my idea has any problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
