Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9206#discussion_r43282659
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/StreamManager.java
---
@@ -47,6 +47,14 @@
public abstract ManagedBuffer getChunk(long streamId, int chunkIndex);
/**
+ * Called in response to a stream() request. The returned data is
streamed to the client
+ * through a single TCP connection.
+ */
+ public ManagedBuffer openStream(String streamId) {
--- End diff --
I wonder if we should use another name for `streamId`, to distinguish it
from the `long streamId` in the other methods here, to avoid confusion. Even
`openStream` could be confused since the existing code also talks about streams
a lot. "unframedStream" is the best I can think of.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
