Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9206#discussion_r43335096
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/StreamManager.java
---
@@ -47,6 +47,14 @@
public abstract ManagedBuffer getChunk(long streamId, int chunkIndex);
/**
+ * Called in response to a stream() request. The returned data is
streamed to the client
+ * through a single TCP connection.
+ */
+ public ManagedBuffer openStream(String streamId) {
--- End diff --
I actually don't like how the other method (`getChunk`) uses "stream" when
it doesn't really stream anything... I dislike "unframedStream" because
"unframed" is irrelevant to the user, it's just being there as a contrived way
to differentiate the two APIs.
I can make the javadoc more explicit about the lack of relationship with
the other method. Maybe `getStreamBuffer`, although that has the same
possibility of confusion with the other method. I do like `openStream` better
than any other variant, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
