Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9344#discussion_r43826213
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -74,26 +78,26 @@ public void spill() throws IOException {
public abstract long spill(long size, MemoryConsumer trigger) throws
IOException;
/**
- * Acquire `size` bytes memory.
+ * Acquire `size` bytes of on-heap execution memory.
*
* If there is not enough memory, throws OutOfMemoryError.
*/
protected void acquireMemory(long size) {
- long got = taskMemoryManager.acquireExecutionMemory(size, this);
+ long got = taskMemoryManager.acquireExecutionMemory(size,
MemoryMode.ON_HEAP, this);
--- End diff --
it's a little confusing that this method only supports ON_HEAP. Maybe
rename the method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
