Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9344#discussion_r43827121
  
    --- Diff: 
core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala ---
    @@ -0,0 +1,138 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.memory
    +
    +import javax.annotation.concurrent.GuardedBy
    +
    +import scala.collection.mutable
    +import scala.collection.mutable.ArrayBuffer
    +
    +import org.apache.spark.{TaskContext, Logging}
    +import org.apache.spark.storage.{MemoryStore, BlockStatus, BlockId}
    +
    +/**
    + * Performs bookkeeping for managing an adjustable-size pool of memory 
that is used for storage
    + * (caching).
    + *
    + * @param memoryManager a [[MemoryManager]] instance to synchronize on
    + */
    +class StorageMemoryPool(memoryManager: Object) extends 
MemoryPool(memoryManager) with Logging {
    +
    +  @GuardedBy("memoryManager")
    +  private[this] var _memoryUsed: Long = 0L
    +
    +  override def memoryUsed: Long = memoryManager.synchronized {
    +    _memoryUsed
    +  }
    +
    +  private var _memoryStore: MemoryStore = _
    +  def memoryStore: MemoryStore = {
    +    if (_memoryStore == null) {
    +      throw new IllegalArgumentException("memory store not initialized 
yet")
    --- End diff --
    
    illegal state?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to