Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1264#discussion_r14333837
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -838,7 +839,16 @@ class DAGScheduler(
cleanupStateForJobAndIndependentStages(job,
Some(stage))
listenerBus.post(SparkListenerJobEnd(job.jobId,
JobSucceeded))
}
- job.listener.taskSucceeded(rt.outputId, event.result)
+
+ // taskSucceeded runs some user code that might throw an
exception. Make sure
+ // we are resilient against that.
+ try {
+ job.listener.taskSucceeded(rt.outputId, event.result)
--- End diff --
Could we wrap a wider area with this try-catch? For instance, we've also
had problems where Accumulators.add throws an exception, and we similarly don't
want the entirety of Spark to crash. I think any unhandled exception in the
handleTaskCompletion method deserves a task failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
