Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1264#discussion_r14336409
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -838,7 +839,16 @@ class DAGScheduler(
cleanupStateForJobAndIndependentStages(job,
Some(stage))
listenerBus.post(SparkListenerJobEnd(job.jobId,
JobSucceeded))
}
- job.listener.taskSucceeded(rt.outputId, event.result)
+
+ // taskSucceeded runs some user code that might throw an
exception. Make sure
+ // we are resilient against that.
+ try {
+ job.listener.taskSucceeded(rt.outputId, event.result)
--- End diff --
I'm going to add a check for accumulators. Good catch. However, I don't
know yet if we want a wider catch because for some changes it might be bad to
change the state. That needs a more careful review of this code block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
