Github user BryanCutler commented on the pull request:

    https://github.com/apache/spark/pull/9317#issuecomment-153850908
  
    Thanks for the feedback @zsxwing !  
    
    >@BryanCutler Could you also make the following variables volatile? They 
are accessed in multiple threads.
    
    >  private var endpoint: RpcEndpointRef = null
    >  private var appId: String = null
    
    I made this change, but would you mind clarifying a little where these are 
shared?  From what I can tell, I think the `RpcEndpointRef` gets wrapped in the 
`NettyRpcCallContext` but `appId` is just copied to the `RequestExecutors` and 
`KillExecutors` messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to