Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43941797
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -208,13 +213,32 @@ private[spark] class AppClient(
case k: KillExecutors =>
master match {
- case Some(m) => context.reply(m.askWithRetry[Boolean](k))
+ case Some(m) => askAndReplyAsync(m, context, k)
case None =>
logWarning("Attempted to kill executors before registering
with Master.")
context.reply(false)
}
}
+ private def askAndReplyAsync[T](
+ endpointRef: RpcEndpointRef,
+ context: RpcCallContext,
+ msg: T): Unit = {
+ // Create a thread to ask a message and reply with the result.
Allow thread to be
+ // interrupted during shutdown, otherwise context must notified of
NonFatal errors.
--- End diff --
nit: must **be** notified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
