Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43947627
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -647,7 +648,7 @@ public boolean putNewKey(Object keyBase, long
keyOffset, int keyLength,
assert(bitset != null);
assert(longArray != null);
- if (numElements == MAX_CAPACITY || !canGrowArray) {
+ if (numElements == MAX_CAPACITY || numElements > growthThreshold &&
!canGrowArray) {
--- End diff --
When we have `numElements <= growthThreshold && !canGrowArray`, it is
guaranteed that our page still has space to put this key, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
