Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43951008
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -83,11 +83,8 @@ public UnsafeKVExternalSorter(
/* initialSize */ 4096,
pageSizeBytes);
} else {
- // The memory needed for UnsafeInMemorySorter should be less than
longArray in map.
- map.freeArray();
- // The memory used by UnsafeInMemorySorter will be counted later
(end of this block)
final UnsafeInMemorySorter inMemSorter = new UnsafeInMemorySorter(
- taskMemoryManager, recordComparator, prefixComparator, Math.max(1,
map.numElements()));
+ taskMemoryManager, recordComparator, prefixComparator,
map.getArray());
--- End diff --
No, the array from map is not thread safe, only accessible from current
thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
