Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9287#discussion_r44046633
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -379,6 +380,16 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
     
       try {
         _conf = config.clone()
    +
    +    // if a secret key has been set in an env variable, use it
    +    for (ns <- Seq(Namespace.Blank, Namespace.Application, 
Namespace.Submission)) {
    +      sys.env.get(ns.inEnv(ENV_AUTH_SECRET))
    --- End diff --
    
    Now that I see the methods being used, the names sound kinda weird. I'd 
prefer `ns.envName` and `ns.confName`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to