Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9287#discussion_r44049779
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -99,8 +98,10 @@ private[spark] class AppClient(
return
}
logInfo("Connecting to master " + masterAddress.toSparkURL +
"...")
- val masterRef =
- rpcEnv.setupEndpointRef(Master.SYSTEM_NAME, masterAddress,
Master.ENDPOINT_NAME)
+ val masterRef = rpcEnv.setupEndpointRef(
--- End diff --
I see changes like this in lots of places. These are not arguments with
default values, so calling them like this is completely unnecessary and just
adds noise. Can you please revert changes like this from your patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
