Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9287#discussion_r44054401
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
    @@ -117,4 +114,15 @@ object CommandUtils extends Logging {
           }
         }.start()
       }
    +
    +  val SystemPropertyPattern = """^-D(.+?)=(.*)$""".r
    --- End diff --
    
    nit: either ALL_CAPS or camelCase. We don't declare variables with names 
like that in Spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to