Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9287#discussion_r44051774
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -126,27 +131,92 @@ private[deploy] class Master(
}
// Alternative application submission gateway that is stable across
Spark versions
- private val restServerEnabled =
conf.getBoolean("spark.master.rest.enabled", true)
- private var restServer: Option[StandaloneRestServer] = None
- private var restServerBoundPort: Option[Int] = None
+ private val restSubmissionServerEnabled =
conf.getBoolean("spark.master.rest.enabled", true)
+ private var restSubmissionServer: Option[StandaloneRestServer] = None
+ private var restSubmissionServerBoundPort: Option[Int] = None
+
+ private var rpcSubmissionEndpointRef: Option[RpcEndpointRef] = None
+
+ object RPCSubmissionEndpoint extends ThreadSafeRpcEndpoint {
--- End diff --
it's not really clear: why do you need this? why can't you just use the
Master itself, since it already handles all these messages?
At the very least, this needs a comment (in the code) explaining that.
Also, nested classes are generally declared at the bottom of the enclosing
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
