Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1272#discussion_r14391299
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -50,11 +50,12 @@ trait SQLConf {
/** ********************** SQLConf functionality methods ************ */
@transient
- private val settings = java.util.Collections.synchronizedMap(
- new java.util.HashMap[String, String]())
+ private val settings = new
java.util.concurrent.ConcurrentHashMap[String, String]()
def set(props: Properties): Unit = {
- props.asScala.foreach { case (k, v) => this.settings.put(k, v) }
+ settings.synchronized {
--- End diff --
Perhaps we can remove this synchronized, I don't think we care about the
consistency guarantees of inserting multiple properties at once :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
