Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1272#discussion_r14391342
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -64,20 +65,21 @@ trait SQLConf {
       }
     
       def get(key: String): String = {
    -    if (!settings.containsKey(key)) {
    -      throw new NoSuchElementException(key)
    -    }
         settings.get(key)
       }
     
       def get(key: String, defaultValue: String): String = {
    -    if (!settings.containsKey(key)) defaultValue else settings.get(key)
    +    settings.synchronized {
    +      if (!settings.containsKey(key)) defaultValue else settings.get(key)
    +    }
       }
     
       def getAll: Array[(String, String)] = settings.asScala.toArray
     
       def getOption(key: String): Option[String] = {
    -    if (!settings.containsKey(key)) None else Some(settings.get(key))
    +    settings.synchronized {
    +      if (!settings.containsKey(key)) None else Some(settings.get(key))
    --- End diff --
    
    Similarly, here, just 
    
    ```scala
    Option(settings.get(key))
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to