Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9480#discussion_r44201576
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -151,6 +164,30 @@ abstract class Expression extends TreeNode[Expression]
{
}
/**
+ * Returns the hash for this expression. Expressions that compute the
same result, even if
+ * they differ cosmetically should return the same hash.
+ */
+ def semanticHash() : Int = {
+ def computeHash(e: Seq[Any]): Int = {
--- End diff --
Whats wrong with `hashCode` on `Seq[Any]`? I think this its just going to
use
[this](https://github.com/scala/scala/blob/27da46343cd545534819300235bc64ab74958c92/src/library/scala/util/hashing/MurmurHash3.scala#L217)
which seems pretty reasonable. Maybe I'm missing something though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
