Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/9480#discussion_r44205755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -151,6 +164,30 @@ abstract class Expression extends TreeNode[Expression]
{
}
/**
+ * Returns the hash for this expression. Expressions that compute the
same result, even if
+ * they differ cosmetically should return the same hash.
+ */
+ def semanticHash() : Int = {
--- End diff --
When you look at the methods `equals`, `semanticEquals` and `hashCode` of
the `AttributeReference`, you will see that they are not matched, as `equals`
will take consideration of the `name`, but the other 2 are not, that's why I am
thinking we can also use the `hashCode`, instead of adding the new method
`semanticHash`.
Anyway, it's not an external API, we can change it back anytime, as 1.6 is
almost code freeze, and this is critical for people now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
