Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/9566#issuecomment-155578114 I'll rebase. The potential bug is caused by the fact that the attributes for the distinct columns and the expressions for the distinct columns can possibly be misaligned. This currently relies on the fact that a sequence maintains the same order as a (hash) map derived from it. This currently works, but is not guaranteed by the scala collections library. I'd rather fix this, than to wait for something to go wrong.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org