Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7888#issuecomment-155593935
I don't see why we need to change the public API. Currently, we have:
```
def killExecutor(executorId: String): Boolean
def killExecutors(executorIds: Seq[String]): Boolean
```
We can keep these and internally make them set force to true. Additionally,
for the ones we use internally to timeout executors, we'll just set force to
false. In other words we end up with:
```
def killExecutor(executorId: String): Boolean =
killExecutors(Seq(executorId))
def killExecutors(executorIds: Seq[String]): Boolean =
killExecutors(executorIds, force = true)
private[spark] def killExecutors(executorIds: Seq[String], force: Boolean)
```
```
// ExecutorAllocationManager
private def removeExecutor(executorId: String): Boolean = {
...
client.killExecutors(Seq(executorId), force = false)
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
