Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155625846
Actually, @feynmanliang I realized as I was trying to rewrite this that
using a lazy val for DistributedLDAModel.oldLocalModel prevents us from one
important optimization in DistributedLDAModel.copy, which is called every time
we call model.transform:
* Currently: We copy the local model if it has been instantiated (involving
collecting the topicsMatrix to the driver).
* With a lazy val: I don't see a good way to ensure the collect only
happens once.
Given that this could mean considerable overhead, including several copies
of topicsMatrix on the driver, I'd prefer to keep the current class structure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
