Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155630055
I still think it's wrong for a `LocalLDAModel` to *optionally* have a
`OldLocalLDAModel` when it's basically a wrapper for `OldLocalLDAModel`.
Forking the inheritance structure could avoid that by making the
`Option[OldLocalLDAModel]` localized to `DistributedLDAModel` (and we can still
have the `copy` iff `collect`ed already semantics) while also removing the
`case Some(...) => ... case None => /* should never happen */`s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
