Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9661#discussion_r44958484
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -173,18 +172,15 @@ private[spark] object HighlyCompressedMapStatus {
var i = 0
var numNonEmptyBlocks: Int = 0
var totalSize: Long = 0
- // From a compression standpoint, it shouldn't matter whether we track
empty or non-empty
- // blocks. From a performance standpoint, we benefit from tracking
empty blocks because
- // we expect that there will be far fewer of them, so we will perform
fewer bitmap insertions.
--- End diff --
This comment still make sense, could you keep it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
